New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update npm package #84
Comments
The We'd have to take the ownership of the package first. @dmethvin & @scottgonzalez, do you think we'd like to do it? BTW, @gnarf, the latest version has been released a long time ago, should we tag a new one? |
I contacted the owner of the module. |
We might want to get the build chain up to date and make sure everything I'm really to busy with my parents estate to do anything about it anytime On Fri, Dec 4, 2015 at 10:23 AM, Scott González notifications@github.com
|
I won't have time before January-February, a lot of work-related changes going on & the upcoming Core releases are enough. If no one steps up I might try later. |
@leobalter We only control the npm package, not the Bower one, do we still want to use jquery-release for publishing or not? Note that if we don't use jquery-release we have to be careful to define a proper |
I honestly don't care about publishing it to bower. We should be fine with npm only.
Unless we want to use the CDN for publishing static files, we should also skip using jquery-release, IMHO. +1 to define .npmignore properly. |
I submitted a PR with There are some issues to fix but we can deal with them after 3.0.0 as most of them don't seem to require breaking changes. |
We still need to publish a new release to npm (which this issue is about) so I'll reopen for now. We still need to somehow ensure I'll try that on a branch and publish to my scoped package to make sure we're fine before doing it here. |
Hi, |
let's get this done, anything I can do to help... I lost a few hours of my life to znetstar that I will never get back... :-) |
We publish to our own CDN: https://code.jquery.com/color/. Perhaps we should continue to do that in that case. Maybe we need jquery-release in the end, otherwise we have to follow those steps by ourselves. |
I've submitted a housekeeping PR I'd like to land shortly, PTAL: #120. |
jQuery Color Please test and report any issues before we release the final! |
FWIW, I've used |
Is that meant to mean its published at https://www.npmjs.com/package/jquery-release? |
@ntwb No, it's published as |
Right, I thought that because https://www.npmjs.com/package/jquery-color still shows the 1.0.0 release from znetstar /shrug
Cheers,
Stephen Edgar
…________________________________
From: Michał Gołębiowski-Owczarek <notifications@github.com>
Sent: Wednesday, February 14, 2018 7:40:18 PM
To: jquery/jquery-color
Cc: Stephen Edgar; Mention
Subject: Re: [jquery/jquery-color] update npm package (#84)
@ntwb<https://github.com/ntwb> No, it's published as jquery-color. You can see your link is a 404.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#84 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AA-Civbazw2Iug5Ji0AJw0Nx_NuMY-3Vks5tUpvygaJpZM4GqT7E>.
|
@ntwb It's because I've only released a pre-release ( In the meantime, please test the alpha, that'll help to release the final sooner. |
just to confirm: is the correspondent npm package |
could you also insert in said package, besides a |
@jfoclpf the package is in preview. If you want to try it, you need to invoke:
I encourage you to test it & submit issues if you discover any. The more people try it, the more likely we'll release a final in a predictable future. |
I tried and it seems great. Though in your I see this in your
That is, For adding a dependency you just need to
I don't think you need to publish as beta, if jquery-color is tested to work fine. |
jQuery is not a dependency but a peerDependency of jQuery Color. This is
because each jQuery plugin should use the same jQuery instance, not its
own. peerDependencies are not enforced by npm to avoid dependency hell
(older npm used to enforce that and even auto-install peerDeps) but you
should see a warning in the console if you don’t install jQuery.
--
Michał Gołębiowski-Owczarek
|
Thanks a lot for the info. I read the article And now I see in package.json
|
jQuery Color 2.2.0 has been released, it's also published to npm. |
I've noticed that npm thinks that
jquery-color
package is still v1.0.0 and that it depends onjQuery
package (contrary to whatpackage.json
currently says).Can you
npm publish
newer version(s) of the package?The text was updated successfully, but these errors were encountered: