Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Housekeeping #120

Merged
merged 11 commits into from Jan 31, 2018
Merged

Housekeeping #120

merged 11 commits into from Jan 31, 2018

Conversation

mgol
Copy link
Member

@mgol mgol commented Jan 24, 2018

I'd like to unblock the npm release (#84) so I'll land this shortly pending any objections. We can always revert problematic changes until we do the final release but I'd like to at least release an alpha for people to test.

Commit summary

@mgol mgol mentioned this pull request Jan 24, 2018
Copy link
Member

@dmethvin dmethvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Copying the jQuery.type code looks like the easiest way to deal with the way it's being used here, otherwise there's a lot of rewriting to do and given the plugin's age it's probably not time well spent.

@mgol
Copy link
Member Author

mgol commented Jan 24, 2018

@dmethvin thanks for a quick review! I've submitted one more fix (#121) and I'd like to release an alpha with them all today or tomorrow.

Before this commit the following code:

    jQuery.Color( { red: 10, green: 20, blue: 30, alpha: 0.4 } )

was incorrectly creating a Color object with the alpha property set to 1.

Fixes #58
Closes #121
@mgol mgol merged commit 730f90c into master Jan 31, 2018
@mgol mgol deleted the housekeeping branch January 31, 2018 12:35
@mgol mgol added this to the 3.0.0 milestone May 6, 2020
@mgol mgol added the build label May 6, 2020
@mgol
Copy link
Member Author

mgol commented May 8, 2020

The QUnit update was kept on master (for a future 3.0.0) but it was reverted on 2.x-stable to maintain IE <9 support there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants