Core: Support the jQuery slim build #346
Conversation
While it'd be hard for Migrate to support all the possible jQuery builds, the slim build is special as it's officially maintained by the jQuery team, published to npm & uploaded to CDNs. This commit adds support for the jQuery slim build in jQuery 3.0.0 & newer. The slim build is now tested next to the regular one. Fixes jquery#345
|
Note that this currently doesn't pass slim builds with jQuery master because apparently the This issue shouldn't block us from landing this PR, though - slim tests are isolated so it's easy to see the regular ones worked. Also, jQuery 4.x is not out yet and all tests pass with both full & slim builds for all tested jQuery 3.x builds. |
|
@dmethvin It's hard to tell, especially that 3.x itself is still way less popular than 1.x/2.x. But I've seen enough people trying it in various places on GitHub, including it in bug reports, etc. that I think it may be more popular than we'd think! Many projects already include a Promise polyfill & they have their own AJAX library, the slim build makes a lot of sense then. |
mgol
changed the title
The `show()`, `hide()` & `toggle()` methods were included in the 3.x jQuery slim build. The jQuery master build accidentally started to exclude them as they were only imported in the effects module and the new Rollup-based build system follows the module dependency graph when excluding modules. To resolve the issue, import the `css/showHide.js` file directly in the main `jquery.js` file. Closes gh-4704 Ref jquery/jquery-migrate#346
While it'd be hard for Migrate to support all the possible jQuery builds,
the slim build is special as it's officially maintained by the jQuery team,
published to npm & uploaded to CDNs.
This commit adds support for the jQuery slim build in jQuery 3.0.0 & newer.
The slim build is now tested next to the regular one.
Fixes #345