Event alias #138
Event alias #138
Conversation
mousewheel.jquery.json
Outdated
| @@ -22,6 +22,6 @@ | |||
| "homepage": "https://github.com/brandonaaron/jquery-mousewheel", | |||
| "download": "https://github.com/brandonaaron/jquery-mousewheel/tags", | |||
| "dependencies": { | |||
| "jquery": ">=1.2.2" | |||
| "jquery": ">=1.7.0" | |||
There was a problem hiding this comment.
Maybe we should just remove this file since we have no plans to resurrect our plugins repo in its current form?
| @@ -12,6 +12,6 @@ | |||
| "test" | |||
| ], | |||
| "dependencies": { | |||
| "jquery": ">=1.2.2" | |||
| "jquery": ">=1.7.0" | |||
There was a problem hiding this comment.
While we're here, drop the obsolete version from bower.json
|
Looks good to me |
|
@jzaefferer added removal of that property |
|
👍 |
|
I'm okay with this change but should we consider it a major break? Bower and npm users should be protected by the dependencies declared in their files but the majority of users are probably just including the file and putting this out as e.g. 3.1.14 may not make things clear. |
|
@dmethvin thats probably a good point we should probably do a full version bump |
|
The readme in test/browserify still says "npm install jquery-browserify", the rest looks wrong, too. Shouldn't it describe how to install |
|
@jzaefferer I opened #150 for that. |
This PR removes all dependency on the jQuery Core event/alias module and deprecated module
It also updates the jQuery core dependency to be >= 1.7.0 to allow this removal.
Browserify build was not working when tested with current browserify updated example to work again and update to use jQuery proper jquery-browserify has not been updated in 3 years.