Skip to content

Commit

Permalink
Dialog: Update to 96e5c24 - keyup apparently doesn't work like I thou…
Browse files Browse the repository at this point in the history
…ght it would everywhere, switching back to keydown.

(cherry picked from commit dfe75e1)
  • Loading branch information
gnarf committed Aug 20, 2011
1 parent 8f16cc3 commit 5d4d40f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tests/unit/dialog/dialog_tickets.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ asyncTest( "#3123: Prevent tabbing out of modal dialogs", function() {

inputs.eq( 1 ).focus();
equal( document.activeElement, inputs[1], "Focus set on second input" );
inputs.eq( 1 ).simulate( "keyup", { keyCode: $.ui.keyCode.TAB });
inputs.eq( 1 ).simulate( "keydown", { keyCode: $.ui.keyCode.TAB });

setTimeout( checkTab, 2 );

Expand Down
2 changes: 1 addition & 1 deletion ui/jquery.ui.dialog.js
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ $.widget("ui.dialog", {

// prevent tabbing out of modal dialogs
if ( options.modal ) {
uiDialog.bind( "keyup.ui-dialog", function( event ) {
uiDialog.bind( "keydown.ui-dialog", function( event ) {
if ( event.keyCode !== $.ui.keyCode.TAB ) {
return;
}
Expand Down

0 comments on commit 5d4d40f

Please sign in to comment.