Skip to content
Permalink
Browse files

Selectmenu: corrections based on code review.

  • Loading branch information...
robertbeuligmann committed Oct 16, 2012
1 parent 20d19db commit 8e1e9562481de41db97dbb4525c01f519d436e74
Showing with 4 additions and 5 deletions.
  1. +4 −5 ui/jquery.ui.selectmenu.js
@@ -73,10 +73,9 @@ $.widget( "ui.selectmenu", {

_drawButton: function() {
var tabindex = this.element.attr( 'tabindex' );
var labelSelector = "label[for='" + this.element.attr("id") + "']";

// Find existing label
this.labelElement = $( labelSelector ).uniqueId();
this.labelElement = $( "label[for='" + this.element.attr("id") + "']" ).uniqueId();

// hide original select tag
this.element.hide();
@@ -89,7 +88,7 @@ $.widget( "ui.selectmenu", {
id: this.ids.button,
width: this.element.outerWidth(),
role: 'combobox',
'aria-labelledby': this.labelElement.attr("id"),
'aria-labelledby': this.labelElement.attr( "id" ),
'aria-expanded': false,
'aria-autocomplete': 'list',
'aria-owns': this.ids.menu,
@@ -157,7 +156,7 @@ $.widget( "ui.selectmenu", {
that.focus = item.index;

// Set ARIA active decendent
that.button.attr( "aria-activedescendant", item.element.uniqueId().attr( "id" ) );
that.button.attr( "aria-activedescendant", item.element.attr( "id" ) );

},
// set ARIA role
@@ -384,7 +383,7 @@ $.widget( "ui.selectmenu", {
// change ARIA attr
this.menuItems.find( "a" ).attr( "aria-selected", false );
this._getSelectedItem().find( "a" ).attr( "aria-selected", true );
this.button.attr( "aria-activedescendant", item.element.uniqueId().attr( "id" ) );
this.button.attr( "aria-activedescendant", item.element.attr( "id" ) );
},

_setOption: function( key, value ) {

3 comments on commit 8e1e956

@scottgonzalez

This comment has been minimized.

Copy link
Member

replied Dec 11, 2013

@robertbeuligmann Can you please sign our CLA?

@robertbeuligmann

This comment has been minimized.

Copy link
Contributor Author

replied Dec 11, 2013

@scottgonzalez

This comment has been minimized.

Copy link
Member

replied Dec 11, 2013

Thanks Robert.

Please sign in to comment.
You can’t perform that action at this time.