Widget: Support events with dashes and colons

[ryakh]

Added support for dashes and colons into the widget component. It will now listen to any triggered event which name contains colon or dash (hyphen).

Fixes #9708

Ref #1158 (closed PR)

Thanks @scottgonzalez for pointing me into the right direction on this one.

[scottgonzalez]

These tests don't verify that the events are working as intended. The implementation could be simply reading everything up to the first colon or dash and trigger that event and all tests would still pass. We need assertions that verify the explicit event types. There's also no need to test for multiple colons and multiple dashes while you have the assertion that combines both.

[ryakh]

Gave events unique names and dropped few tests as you suggested. Anything else?

[scottgonzalez]

They do have unique names now, but you're still not verifying that your'e getting the correct event.type for each one.

[scottgonzalez]

The correct spelling is "divided", though I wouldn't really use that word since nobody is using dashes as a divider, they're using them as spacers. How about "with:colons", "with-dashes", "with-dashes:and-colons"?

[ryakh]

Ah damn typo. Anyway fixed it the way you suggested. Okay so now we are triggering different event for each expression; is that the way you meant it?

The build fails due to "unknown property 'touch-action'", which by my guess is caused by 28310ff. Despite the error the widget tests (alongside with all other tests) should pass.

[jzaefferer]

You may have to run npm update or rm -rf node_modules && npm install to get the latest version of grunt-contrib-csslint or its dependencies.

[scottgonzalez]

Okay so now we are triggering different event for each expression; is that the way you meant it?

Yup. I'll squash and land this right now.

[scottgonzalez]

Actually, you signed the CLA with a different email address than the commit. Which email address did you want to use?

[ryakh]

Hmm I thought I've signed it with ruslan@ruslan.io (which is the one listed on github). NVM — signed it again using the email address.

[scottgonzalez]

You did sign the CLA with that address, but your git config uses the .sk address (the address you have set in GitHub is irrelevant). I'll change the commit to use .io.

[usmonster]

Any reason this isn't /^([\w:-]+)\s*(.*)$/ instead?

[scottgonzalez]

If I had written it, that's what I would have used as it more accurately represents what we're looking for. In practice it won't matter though; the only difference occurs on invalid input.