Theme update #1436
Theme update #1436
Conversation
.ui-widget-shadow was created when box-shadow wasn't available. By now, there's no point in faking a custom shadow anymore. This removes the only non-structural CSS from a widget-specific file.
jzaefferer
force-pushed
the
theme-update
branch
from
d2eb0c9
to
a2db620
Compare
|
Also rebased this, so that we get the menu state update. |
|
I will look into overlay and shadow colors/opacity. Removing the background image from overlay sounds good. I don't have access to the jquery-ui repo, but I can do a PR against the theme-update branch. |
|
I just added you to the UI team on GitHub, that way you can just push to this branch, we don't need even more PRs. Just don't force-push to master ;-) |
|
@jaspermdegroot thanks for the update. Since there are no notifications for commits, can you comment here when adding something? Otherwise, what Rafael said. Bringing back the variables should make this good to land. |
|
We are discussing "bringing back the comments/variables" on IRC. It will cause issues. Update: The conclusion is that we shouldn't bring back those comments/variables. |
|
@jaspermdegroot do you know of anything missing here? I think this is ready to land. |
|
@jzaefferer - I think it's ready too. |
|
Squashed and merged. I've created #10880 to track the tooltip change, also fixed by this PR. |
Make "Base" the default, while "UI Smoothness" and "UI Lightness" will still be available in the gallery. Change the flat texture to not use a flat image anymore, only the css background color is set. Update markup and styles for zip index.html for 1.12.0 package. Closes #248 Ref jquery/jquery-ui#1436
These are still needed. Ref gh-1436 Ref jquery/download.jqueryui.com#248
This replaces #1420, which replaced #1384. Its the same branch for now, but I pushed it to this repo, so that Jasper can contribute to it directly.
I've been testing the new theme with Rafael in ThemeRoller and the custom demo that Download Builder creates. We noticed that the background of
.ui-widget-overlayis darker than thebox-shadowof.ui-widget-shadow, causing the shadow to disappear completely when on top of the overlay. In addition, the overlay doesn't need a background image, it works fine with just a color value. So our suggestion is to remove theurl()from the overlay background, and change the color for overlay or shadow, or both, to work together.@jaspermdegroot would be great if you could look into the above. You could push directly to this branch (let me know if you don't have access, I can fix that).