position of each items should be refreshed for sortable #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
position of each items should be refreshed when div scroll up/down. The previous code didn't refresh the position, so it calculate with wrong information of items when inner div's scroll up or down. I have tested it with more than 20 of 500 ~ 2000px items.
|
Thanks, please start with a ticket in http://bugs.jqueryui.com including a reduced test case showing the problem. We'll also want some unit tests showing that this fixes the problem and preventing regressions. You should read the contributing guidelines for full information. |
|
Ok. I'll do it after the project I'm working on is almost done. |
|
I'm going to close this for now, we can revisit when you have time to work on this again and file the bug report. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
position of each items should be refreshed when div scroll up/down.
The previous code didn't refresh the position, so it calculate with wrong information of items when inner div's scroll up or down.
I have tested it with more than 20 of 500 ~ 2000px items.