Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog: Remove overflow: hidden and reposition resize handles #1439

Merged
merged 1 commit into from
Jan 29, 2015

Conversation

tjvantoll
Copy link
Member

The background-position: 16px 16px; on the SE handle doesn't seem to be necessary now that the handle is small so I removed it.

I tested this on a few browsers on my Mac and some Windows VMs and it looks to be good. I still think these targets are too small, but by design this PR keeps the status quo.

@tjvantoll tjvantoll changed the title Dialog: Remove overflow: hidden and reposition resize handlers Dialog: Remove overflow: hidden and reposition resize handles Jan 28, 2015
@scottgonzalez
Copy link
Member

Looks good.

@jzaefferer
Copy link
Member

Will this cause problems if we try to make the handles larger, later? If not, I'm good with landing this now and creating a follow-up ticket to make the handles bigger. The latter should also take touch screens into account.

@scottgonzalez
Copy link
Member

Do you mean if we make the handles bigger in resizable or dialog? In either case, dialog has defined both dimensions and positions, so changes are always isolated. This doesn't change anything, honestly, other than the ability to remove overflow: hidden. The handles are the exact same size as they were before, and making them bigger after this change will have the same effect (positive or negative) as making them bigger without this change.

@jzaefferer
Copy link
Member

Alright, let's land this and create the follow-up ticket.

@tjvantoll tjvantoll merged commit 912eb62 into jquery:master Jan 29, 2015
@tjvantoll
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants