Calendar / Datepicker: Fixes focus and tab index handling #1658
Conversation
History is on the datepicker-dead branch.
Use the `eachDay` option in the other-months demo. Fix handling of `extraClasses` property, split on space.
This is specifically for multi month pickers. This makes the assumption that the keyboard is always interacting with the first month in a multi month calendar. The next step is to store which grid currently has focus and to base the focus logic off of that.
* Re-add `ui-datepicker-week-col` class name currently used. * Add test suite. * Support changing option after initialization.
Move methods to prototype.
Make `select()` a private method as it's not part of the specification.
Revert to old behavior with two instead of three chars. Fixes layout issue with wrong day table cell width.
Change status caching, fix existing value related methods, introduce $.date construction with date object, selected property is null by default, add selected getter
|
By analyzing the blame information on this pull request, we identified @arschmitz, @scottgonzalez and @jzaefferer to be potential reviewers |
|
Still not perfect but much improved a11y in this branch. I think we'll need to discuss some details of the proposed a11y specs in the wiki. The spec lacks information about how to handle multiple calendars, has some focus related difference and differs from the current implementation in general. Should I just merge all master / merge commits to datepicker branch? Somewhat ugly to review the actual changes at the moment... @jzaefferer FYI: most of the above mentioned wiki issues (see PR description) have been reported by you in former PRs. |
I just review individual commits rather than using the full diff when the changes are this big. Next time you can do this as two branches. One with just the merge and then another with your changes on top of that. Then you can send the PR against the branch with just the merge so the PR diff only shows the new code. |
* Change next / prev button structure for better tabindex * Improve focus and active handling
Remove unneeded tabindex attribute change. Set focus to input after tab, let default behavior decide which elements gains focus next.
fnagel
force-pushed
the
datepicker-focus-issues
branch
from
b506fc2
to
f04a393
Compare
|
@scottgonzalez Reminder for another review (as asked for). Not sure which commits you have already seen but I guess this should be new for you: Fix tab index for prev / next buttons, Fix focus after date selection and after leaving the widget by using tab, Do not rebuilt whole calendar when a date is selected |
|
Is there any reason to have the merge commit in this PR? Seems like it makes things unnecessarily complicated to review. PS:
If its a straightforward merge (no conflicts), yes please. PPS: I should read everything first |
Datepicker will have always merge conflicts with master. I will create two PRs next time (see Scotts response). |
|
Travis build failed with on date unit tests: Testing tests/unit/date/date.html ..........F..
>> date: core - Months
>> Message: null
>> Actual: 11
>> Expected: -1Is that the same issue we were looking at before, but with improved output? Or something else? |
That's the issue we talked about in the last PR: #1651 (comment) and following |
|
Closed in favor of #1660. Merge and some clean up commits have been merged into datepicker branch. |
This should fix all "Focus related" issues in the wiki: http://wiki.jqueryui.com/w/page/12137778/Datepicker
See section "6 - Open issues being discussed" -> "Next Steps / ToDo"