Droppable: Improve over/out events detection, when greedy option is used #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9389 and probably some others.
JSFiddle with the problem: http://jsfiddle.net/xhcofgvx/
JSFiddle with this fix: http://jsfiddle.net/xhcofgvx/3/
Obsoletes this PR: #1770
The logic changed to do two loops instead of one.
First one detects all droppables that should toggle over/out state, taking into consideration greedy option on inner droppables.
Second loop does the actual state change.
Also test is added, that fails without these commit.