Autocomplete: Make the change event synchronous #508
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the change event synchronous, fixing http://bugs.jqueryui.com/ticket/7550 (form submit occurs before autocompletechange event).
There used to be a few timeouts to deal with timing issues. These timeouts caused their own problems, which we had to code around. As a result, we had tests around this functionality. I've deleted these tests as they're no longer relevant. The one that I was most concerned with was the fix for slow clicks (http://bugs.jqueryui.com/ticket/5405). This seems to work fine now that the close-on-blur timeout is gone.
I'd appreciate a review of this in case anyone can think of something I may have missed by making this change.