Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Accordion: Attempt at improving animation. #587
This is an attempt at fixing #4178.
The logic is to use core as much as possible, then override the animation of the height of the panel being shown. Most browsers don't support fractional pixels, and even browsers that do support fractions can't handle the level of precision that we get during an animation. This causes the combined height of the panel being shown and the panel being hidden to jump around a bit during the animation. We try to deal with that by recalculating the total height at each step of the animation and adjusting the height of the panel being shown to account for any pixels that were lost or gained by the browser not being able to handle the exact values that were calculated by
This works great in Chrome and Opera. It's ok in IE and not so great in Firefox. However, this is better than what we have now in all browsers.
This code should not e committed as is.