Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a Firefox bug caused by a previous focus fix. #645

Closed
wants to merge 1 commit into from

Conversation

coling
Copy link

@coling coling commented May 2, 2012

...ocus fix causes Firefox Security Manager veto.

…- focus fix causes Firefox Security Manager veto.
@scottgonzalez
Copy link
Member

Closing since we don't have a test case that shows the problem.

@gnarf
Copy link
Member

gnarf commented May 2, 2012

Not to mention, I'm not a fan of the catch & release...

@scottgonzalez
Copy link
Member

@gnarf37 I agree the try/catch around the whole block is bad. We can wrap the $.contains() call as that should never throw under normal circumstances. I'll see if there's anything else we can do that won't throw, but so far nothing is working. It's annoying that even with the try/catch we'll lose focus though.

@gnarf
Copy link
Member

gnarf commented May 3, 2012

Focus on <input type="file"> is iffy at best I think.

@scottgonzalez
Copy link
Member

@gnarf37 Why is that? Just because it's inconsistent across browsers? I think it's fine if we have to lose focus. There's absolutely nothing we can do here. This is a major bug, I'm surprised that Mozilla has let it site; it totally breaks the use document.activeElement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants