Resizable: Modified the default z-index value of resizable handles. Fix...

[tjvantoll]

...ed #7960 - Dialog: Modal dialogs do not disable resizables on the page.

See http://bugs.jqueryui.com/ticket/7960.

I was a little torn about adding the inline comment. 90 is kind of a random number so I thought having a reference might help.

[mikesherov]

Unit tests?

[mikesherov]

stylistically, top down comments are preferred to EOL comments:

// See #7960
zIndex: 90

[tjvantoll]

@mikesherov Good call. I'll add a test that makes sure the z-index of a resizable is less than the modal dialog's overlay.

[tjvantoll]

@mikesherov I changed the formatting and added a test.

[mikesherov]

Much better! In general, I'll only land pull requests without tests if its not practical to do so. Thanks for updating.

[gnarf]

:sigh: - zIndex cc @scottgonzalez

Do we really need a zIndex at all here? I know we've been evaluating our (ab)use of zIndex in other places.

[mikesherov]

zIndex wars are like !important wars. Programatic zIndex assignment would be better IMO, but what I really personally care about is the test. As long as these are getting covered, we can try any approach you like :)

[tjvantoll]

@gnarf37 Yeah I guess I've never really considered why the resizable plugin blindly assignes a z-index in the first place.

z-index is only used in two places in the entire file.

• Line 120 simply applies the zIndex option value to all handles.
• Line 579 adds the zIndex plus 1 to the proxy wrapper element if it's necessary.

I did some testing and if I simply remove those lines the plugin still works just fine. That being said I only tried some basic use cases on Chrome.

If no one knows of why this option is needed in the first place I can test this more thoroughly (hit all the options, browsers, etc).

[mikesherov]

I'm, as usual, against a complete removal of zIndex until we do a full git blame to see where and why it was introduced.

[tjvantoll]

@mikesherov The option has been in there since the beginning of git time. The initial version in git has pretty the exact same 2 lines I reference above. That being said I'm sure there must be a reason, and I'm guessing it's related to the proxy element.

I'm mostly curious at this point.

[scottgonzalez]

I think it's just because we want the handles to be on top of all content, even if the content has a z-index applied. This should really just be moved to the stylesheet and the option should be dropped, but that won't happen until 2.0.

[gnarf]

@scottgonzalez thanks for the direction - Do we have a ticket to track these zIndex uses for removal in 2.0?

[scottgonzalez]

@gnarf37 The tickets will be created when we announce the API redesign for resizable. The change in this PR will just go against the dialog ticket.

[mikesherov]

Ok, then I'm going to land as is.

[jzaefferer]

Landed in 0cd470b - squashed three commits into one, fixed whitespace in test, included button widget along with dialog dependency.

[scottgonzalez]

Not sure why I missed this before, the test should be in dialog, not resizable.

[jzaefferer]

Fixed in ee8d20e

[tjvantoll]

Thanks @jzaefferer.