Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resizable: Modified the default z-index value of resizable handles. Fix... #840

Closed
wants to merge 3 commits into from
Closed

Resizable: Modified the default z-index value of resizable handles. Fix... #840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b7455
Resizable: Modified the default z-index value of resizable handles. …
tjvantoll Nov 24, 2012
0f68f54
Reformatting inline comment per suggestion.
tjvantoll Nov 24, 2012
5a5f98f
Adding a test to make sure that a resizable has a lower z-index then …
tjvantoll Nov 24, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/unit/resizable/resizable.html
View file
Open in desktop
Expand Up @@ -16,6 +16,7 @@
"ui/jquery.ui.core.js",
"ui/jquery.ui.widget.js",
"ui/jquery.ui.mouse.js",
"ui/jquery.ui.dialog.js",
"ui/jquery.ui.resizable.js"
]
});
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/resizable/resizable_common.js
View file
Open in desktop
Expand Up @@ -19,7 +19,7 @@ TestHelpers.commonWidgetTests('resizable', {
maxWidth: null,
minHeight: 10,
minWidth: 10,
zIndex: 1000,
zIndex: 90,

// callbacks
create: null
Expand Down
14 changes: 14 additions & 0 deletions tests/unit/resizable/resizable_options.js
View file
Open in desktop
Expand Up @@ -210,4 +210,18 @@ test("zIndex, applied to all handles", function() {
});
});

test( "zIndex, less than a modal dialog's overlay by default", function() {
expect(1);

var resizable = $( '<div></div>' ).resizable();
var dialog = $( '<div></div>' ).dialog( { modal: true });

var resizableZIndex = resizable.resizable( 'option', 'zIndex' );
var overlayZIndex = $( '.ui-widget-overlay' ).css( 'zIndex' );
overlayZIndex = parseInt( overlayZIndex, 10 );

ok( resizableZIndex < overlayZIndex, "Resizables behind a modal dialog must have a smaller z-index than the overlay so that they're not resizable. See #7960." );
dialog.dialog( 'destroy' );
});

})(jQuery);
3 changes: 2 additions & 1 deletion ui/jquery.ui.resizable.js
View file
Open in desktop
Expand Up @@ -42,7 +42,8 @@ $.widget("ui.resizable", $.ui.mouse, {
maxWidth: null,
minHeight: 10,
minWidth: 10,
zIndex: 1000
// See #7960
zIndex: 90
},
_create: function() {

Expand Down