Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to jQuery 3 #400

Closed
mgol opened this issue Sep 19, 2016 · 12 comments · Fixed by #440
Closed

Upgrade to jQuery 3 #400

mgol opened this issue Sep 19, 2016 · 12 comments · Fixed by #440

Comments

@mgol
Copy link
Member

mgol commented Sep 19, 2016

Currently our sites use jQuery 1.11.3. We should switch to jQuery 3 (eating our own dogfood etc.).

cc @dmethvin @timmywil

Note that this doesn't apply to examples on various API sites which have jQuery copies versioned in repositories specific to those sites.

@mgol
Copy link
Member Author

mgol commented Sep 19, 2016

@timmywil
Copy link
Member

timmywil commented Jun 22, 2023

We'll need to test each site individually, and if any fail in a way that is not trivial to fix, we'll need to parameterize the jQuery version. Here is the comprehensive list:

  • jquery.com
  • blog.jquery.com does not load jquery-wp-content
  • api.jquery.com
  • plugins.jquery.com
  • learn.jquery.com
  • jqueryui.com
  • blog.jqueryui.com does not load jquery-wp-content
  • api.jqueryui.com
  • jquery.org needs redirects to openjsf.org
  • jquerymobile.com
  • api.jquerymobile.com
  • brand.jquery.org
  • contribute.jquery.org
  • meetings.jquery.org
  • releases.jquery.com

@mgol
Copy link
Member Author

mgol commented Jun 22, 2023

jquery.org doesn't fully redirect to openjsf.org. Its home page & some other pages do but e.g. https://jquery.org/team/ is not redirected, the same applies to https://jquery.org/history/.

Although, these pages look quite obsolete. Maybe we should make sure everything gets redirected and kill the site completely.

@timmywil
Copy link
Member

Thanks. I didn't notice that, but I agree we can kill the site.

@mgol
Copy link
Member Author

mgol commented Jun 22, 2023

The history site can be quite interesting. It stopped getting updated in 2014 and many links are dead and would have to be rewritten with Web Archive but still.

@timmywil
Copy link
Member

I think if we wanted a page like that, we should just redo it static. As it's been broken for a while and not updated, I'd like to redirect and maybe add a history page later.

@timmywil
Copy link
Member

All sites pass locally. The pages in demos and examples are loaded in iframes and have their own versions of jquery. I'm fairly confident we don't need to parameterize.

@mgol
Copy link
Member Author

mgol commented Jun 28, 2023

Good to hear!

timmywil added a commit to timmywil/jquery-wp-content that referenced this issue Jun 28, 2023
@timmywil
Copy link
Member

I would like to point out that whatever theme the blogs are loading has an even older version of jQuery than jquery-wp-content. That could also be upgraded, but I'd need to be pointed to where those themes are.

@timmywil
Copy link
Member

Nevermind, I think I found it https://github.com/jquery/blog.jquery.com-theme

@timmywil
Copy link
Member

Opened jquery/blog.jquery.com-theme#6 on the blog theme

Krinkle pushed a commit that referenced this issue Jul 3, 2023
@timmywil
Copy link
Member

timmywil commented Jul 3, 2023

I've run through all the staging sites and they look good to go. The only one I couldn't view was http://stage.jquerymobile.com. It's showing a 500 "Error establishing a database connection".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants