Skip to content

Commit

Permalink
Build: Run pretest before test:* npm scripts
Browse files Browse the repository at this point in the history
Build was already happening in scripts like `test:browser` but those scripts
were missing `pretest`, meaning that running `npm install && npm test:browser`
may have failed if `pretest` wasn't run before or if its results were out of
date.

Even worse, with such stale data some tests may erroneously succeed.

This also removes a separate `pretest` step from GitHub Actions as it's no
longer needed.

Closes gh-5338
  • Loading branch information
mgol committed Oct 16, 2023
1 parent ace646f commit 1ad66ae
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 11 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/node.js.yml
Expand Up @@ -74,9 +74,6 @@ jobs:
run: npm run build:all && npm run lint
if: matrix.NODE_VERSION == '18.x'

- name: Prepare tests
run: npm run pretest

- name: Run tests
env:
BROWSERS: ${{ matrix.BROWSERS }}
Expand Down
16 changes: 8 additions & 8 deletions package.json
Expand Up @@ -52,14 +52,14 @@
"pretest": "npm run qunit-fixture && npm run babel:tests && npm run npmcopy",
"qunit-fixture": "node build/tasks/qunit-fixture.js",
"start": "node -e \"require('./build/tasks/build.js').buildDefaultFiles({ watch: true })\"",
"test:browserless": "npm run test:node_smoke_tests && npm run test:promises_aplus && npm run test:jsdom",
"test:browser": "npm run build:all && grunt karma:main",
"test:esmodules": "npm run build:main && grunt karma:esmodules",
"test:jsdom": "npm run build:main && grunt test:jsdom",
"test:no-deprecated": "npm run build -- -e deprecated && grunt karma:main",
"test:selector-native": "npm run build -- -e selector && grunt karma:main",
"test:slim": "npm run build -- --slim && grunt karma:main",
"test:node_smoke_tests": "npm run build:all && node build/tasks/node_smoke_tests.js",
"test:browserless": "npm run pretest && npm run test:node_smoke_tests && npm run test:promises_aplus && npm run test:jsdom",
"test:browser": "npm run pretest && npm run build:all && grunt karma:main",
"test:esmodules": "npm run pretest && npm run build:main && grunt karma:esmodules",
"test:jsdom": "npm run pretest && npm run build:main && grunt test:jsdom",
"test:no-deprecated": "npm run pretest && npm run build -- -e deprecated && grunt karma:main",
"test:selector-native": "npm run pretest && npm run build -- -e selector && grunt karma:main",
"test:slim": "npm run pretest && npm run build -- --slim && grunt karma:main",
"test:node_smoke_tests": "npm run pretest && npm run build:all && node build/tasks/node_smoke_tests.js",
"test:promises_aplus": "npm run build:main && node build/tasks/promises_aplus_tests.js",
"test": "npm run build:all && npm run lint && npm run test:browserless && npm run test:browser && npm run test:esmodules && npm run test:slim && npm run test:no-deprecated && npm run test:selector-native"
},
Expand Down

0 comments on commit 1ad66ae

Please sign in to comment.