Skip to content

Commit

Permalink
Changed .jshintrc predef lists to globals objects.
Browse files Browse the repository at this point in the history
  • Loading branch information
stevenbenner authored and dmethvin committed Mar 26, 2013
1 parent f319f42 commit 237413e
Show file tree
Hide file tree
Showing 3 changed files with 43 additions and 42 deletions.
1 change: 1 addition & 0 deletions AUTHORS.txt
Expand Up @@ -164,3 +164,4 @@ Andrew Plummer <plummer.andrew@gmail.com>
Nguyen Phuc Lam <ruado1987@gmail.com>
Dmitry Gusev <dmitry.gusev@gmail.com>
Michał Gołębiowski <m.goleb@gmail.com>
Steven Benner <admin@stevenbenner.com>
10 changes: 5 additions & 5 deletions src/.jshintrc
Expand Up @@ -16,9 +16,9 @@
"browser": true,
"wsh": true,

"predef": [
"jQuery",
"define",
"module"
]
"globals": {
"jQuery": true,
"define": true,
"module": true
}
}
74 changes: 37 additions & 37 deletions test/.jshintrc
Expand Up @@ -15,41 +15,41 @@
"devel": true,
"wsh": true,

"predef": [
"DOMParser",
"jQuery",
"QUnit",
"module",
"ok",
"equal",
"test",
"asyncTest",
"notEqual",
"deepEqual",
"strictEqual",
"notStrictEqual",
"start",
"stop",
"expect",
"raises",
"ajaxTest",
"testIframe",
"testIframeWithCallback",
"createDashboardXML",
"createXMLFragment",
"moduleTeardown",
"testFoo",
"url",
"t",
"q",
"amdDefined",
"fireNative",
"Globals",
"hasPHP",
"isLocal",
"originaljQuery",
"$",
"original$",
"externalHost"
]
"globals": {
"DOMParser": true,
"jQuery": true,
"QUnit": true,
"module": true,
"ok": true,
"equal": true,
"test": true,
"asyncTest": true,
"notEqual": true,
"deepEqual": true,
"strictEqual": true,
"notStrictEqual": true,
"start": true,
"stop": true,
"expect": true,
"raises": true,
"ajaxTest": true,
"testIframe": true,
"testIframeWithCallback": true,
"createDashboardXML": true,
"createXMLFragment": true,
"moduleTeardown": true,
"testFoo": true,
"url": true,
"t": true,
"q": true,
"amdDefined": true,
"fireNative": true,
"Globals": true,
"hasPHP": true,
"isLocal": true,
"originaljQuery": true,
"$": true,
"original$": true,
"externalHost": true
}
}

1 comment on commit 237413e

@scottgonzalez
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't some of these be false so they're treated as read-only?

Please sign in to comment.