Add sparse array performance improvement for inArray. Thanks rwaldron…

…, rkatic, and jdalton
jquery · Sep 19, 2011 · 29c52b0 · 29c52b0
1 parent 76a84fb
commit 29c52b0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/core.js b/src/core.js
@@ -694,7 +694,8 @@ jQuery.extend({
 			i = i ? i < 0 ? Math.max( 0, len + i ) : i : 0;
 
 			for ( ; i < len; i++ ) {
-				if ( array[ i ] === elem ) {
+				// Skip accessing in sparse arrays
+				if ( i in array && array[ i ] === elem ) {
 					return i;
 				}
 			}

diff --git a/test/unit/attributes.js b/test/unit/attributes.js
@@ -156,7 +156,7 @@ test("attr(Hash)", function() {
 });
 
 test("attr(String, Object)", function() {
-	expect(77);
+	expect(78);
 
 	var div = jQuery("div").attr("foo", "bar"),
 		fail = false;