Fix #14101: $().data() should be undefined, not null

jquery · Nov 6, 2013 · 30eee92 · 30eee92
1 parent cc19a6b
commit 30eee92
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/data.js b/src/data.js
@@ -75,8 +75,7 @@ jQuery.extend({
 
 jQuery.fn.extend({
 	data: function( key, value ) {
-		var i, name,
-			data = null,
+		var i, name, data,
 			elem = this[ 0 ],
 			attrs = elem && elem.attributes;
 

diff --git a/test/unit/data.js b/test/unit/data.js
@@ -170,6 +170,12 @@ test("jQuery.data(object/flash)", 25, function() {
 	dataTests( flash );
 });
 
+// attempting to access the data of an undefined jQuery element should be undefined
+test("jQuery().data() === undefined (#14101)", 2, function() {
+	strictEqual(jQuery().data(), undefined);
+	strictEqual(jQuery().data("key"), undefined);
+});
+
 test(".data()", function() {
 	expect(5);