Skip to content

Commit

Permalink
Fix #13743. Remove deprecated support.boxModel. Close gh-1231.
Browse files Browse the repository at this point in the history
add myself to AUTHORS.txt
  • Loading branch information
mgol authored and dmethvin committed Apr 18, 2013
1 parent 0db70aa commit 35784a8
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 19 deletions.
1 change: 1 addition & 0 deletions AUTHORS.txt
Expand Up @@ -162,4 +162,5 @@ Jean Boussier <jean.boussier@gmail.com>
Adam Coulombe <me@adam.co> Adam Coulombe <me@adam.co>
Andrew Plummer <plummer.andrew@gmail.com> Andrew Plummer <plummer.andrew@gmail.com>
Dmitry Gusev <dmitry.gusev@gmail.com> Dmitry Gusev <dmitry.gusev@gmail.com>
Michał Gołębiowski <m.goleb@gmail.com>
Brandon Johnson <bjohn465+github@gmail.com> Brandon Johnson <bjohn465+github@gmail.com>
3 changes: 0 additions & 3 deletions src/support.js
Expand Up @@ -66,9 +66,6 @@ jQuery.support = (function( support ) {
// Where outerHTML is undefined, this still works // Where outerHTML is undefined, this still works
support.html5Clone = document.createElement("nav").cloneNode( true ).outerHTML !== "<:nav></:nav>"; support.html5Clone = document.createElement("nav").cloneNode( true ).outerHTML !== "<:nav></:nav>";


// jQuery.support.boxModel DEPRECATED in 1.8 since we don't support Quirks Mode
support.boxModel = document.compatMode === "CSS1Compat";

// Will be defined later // Will be defined later
support.inlineBlockNeedsLayout = false; support.inlineBlockNeedsLayout = false;
support.shrinkWrapBlocks = false; support.shrinkWrapBlocks = false;
Expand Down
17 changes: 1 addition & 16 deletions test/unit/support.js
@@ -1,11 +1,5 @@
module("support", { teardown: moduleTeardown }); module("support", { teardown: moduleTeardown });


test("boxModel", function() {
expect( 1 );

equal( jQuery.support.boxModel, document.compatMode === "CSS1Compat" , "jQuery.support.boxModel is sort of tied to quirks mode but unstable since 1.8" );
});

test( "zoom of doom (#13089)", function() { test( "zoom of doom (#13089)", function() {
expect( 1 ); expect( 1 );


Expand Down Expand Up @@ -76,7 +70,6 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo
"radioValue":true, "radioValue":true,
"checkClone":true, "checkClone":true,
"appendChecked":true, "appendChecked":true,
"boxModel":true,
"reliableHiddenOffsets":true, "reliableHiddenOffsets":true,
"ajax":true, "ajax":true,
"cors":true, "cors":true,
Expand Down Expand Up @@ -110,7 +103,6 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo
"radioValue":false, "radioValue":false,
"checkClone":true, "checkClone":true,
"appendChecked":true, "appendChecked":true,
"boxModel":true,
"reliableHiddenOffsets":true, "reliableHiddenOffsets":true,
"ajax":true, "ajax":true,
"cors":true, "cors":true,
Expand Down Expand Up @@ -144,7 +136,6 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo
"radioValue":false, "radioValue":false,
"checkClone":true, "checkClone":true,
"appendChecked":true, "appendChecked":true,
"boxModel":true,
"reliableHiddenOffsets":true, "reliableHiddenOffsets":true,
"ajax":true, "ajax":true,
"cors":true, "cors":true,
Expand Down Expand Up @@ -178,7 +169,6 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo
"radioValue":false, "radioValue":false,
"checkClone":true, "checkClone":true,
"appendChecked":true, "appendChecked":true,
"boxModel":true,
"reliableHiddenOffsets":true, "reliableHiddenOffsets":true,
"ajax":true, "ajax":true,
"cors":false, "cors":false,
Expand Down Expand Up @@ -212,7 +202,6 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo
"radioValue":false, "radioValue":false,
"checkClone":true, "checkClone":true,
"appendChecked":true, "appendChecked":true,
"boxModel":true,
"reliableHiddenOffsets":false, "reliableHiddenOffsets":false,
"ajax":true, "ajax":true,
"cors":false, "cors":false,
Expand All @@ -223,7 +212,6 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo
expected = { expected = {
"ajax": true, "ajax": true,
"appendChecked": false, "appendChecked": false,
"boxModel": true,
"changeBubbles": false, "changeBubbles": false,
"checkClone": false, "checkClone": false,
"checkOn": true, "checkOn": true,
Expand Down Expand Up @@ -280,7 +268,6 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo
"radioValue":false, "radioValue":false,
"checkClone":false, "checkClone":false,
"appendChecked":false, "appendChecked":false,
"boxModel":true,
"reliableHiddenOffsets":false, "reliableHiddenOffsets":false,
"ajax":true, "ajax":true,
"cors":false, "cors":false,
Expand Down Expand Up @@ -314,7 +301,6 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo
"radioValue":true, "radioValue":true,
"checkClone":false, "checkClone":false,
"appendChecked":false, "appendChecked":false,
"boxModel":true,
"reliableHiddenOffsets":true, "reliableHiddenOffsets":true,
"ajax":true, "ajax":true,
"cors":true, "cors":true,
Expand Down Expand Up @@ -348,7 +334,6 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo
"radioValue":true, "radioValue":true,
"checkClone":true, "checkClone":true,
"appendChecked":true, "appendChecked":true,
"boxModel":true,
"reliableHiddenOffsets":true, "reliableHiddenOffsets":true,
"ajax":true, "ajax":true,
"cors":true, "cors":true,
Expand All @@ -359,7 +344,7 @@ testIframeWithCallback( "box-sizing does not affect jQuery.support.shrinkWrapBlo


if ( expected ) { if ( expected ) {
test("Verify that the support tests resolve as expected per browser", function() { test("Verify that the support tests resolve as expected per browser", function() {
expect( 31 ); expect( 30 );


for ( var i in expected ) { for ( var i in expected ) {
if ( jQuery.ajax || i !== "ajax" && i !== "cors" ) { if ( jQuery.ajax || i !== "ajax" && i !== "cors" ) {
Expand Down

0 comments on commit 35784a8

Please sign in to comment.