Skip to content

Commit

Permalink
Revert "Event: Trigger checkbox and radio click events identically"
Browse files Browse the repository at this point in the history
This reverts commit b442aba.
  • Loading branch information
timmywil committed Mar 20, 2017
1 parent 473d2ea commit 4d6b453
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 11 deletions.
10 changes: 3 additions & 7 deletions src/event.js
Expand Up @@ -3,15 +3,13 @@ define( [
"./var/document",
"./var/documentElement",
"./var/rnothtmlwhite",
"./var/rcheckableType",
"./var/slice",
"./data/var/dataPriv",
"./core/nodeName",

"./core/init",
"./selector"
], function( jQuery, document, documentElement, rnothtmlwhite,
rcheckableType, slice, dataPriv, nodeName ) {
], function( jQuery, document, documentElement, rnothtmlwhite, slice, dataPriv, nodeName ) {

"use strict";

Expand Down Expand Up @@ -477,11 +475,9 @@ jQuery.event = {
},
click: {

// For checkable types, fire native event so checked state will be right
// For checkbox, fire native event so checked state will be right
trigger: function() {
if ( rcheckableType.test( this.type ) &&
this.click && nodeName( this, "input" ) ) {

if ( this.type === "checkbox" && this.click && nodeName( this, "input" ) ) {
this.click();
return false;
}
Expand Down
6 changes: 3 additions & 3 deletions src/manipulation.js
Expand Up @@ -2,8 +2,8 @@ define( [
"./core",
"./var/concat",
"./var/push",
"./var/rcheckableType",
"./core/access",
"./manipulation/var/rcheckableType",
"./manipulation/var/rtagName",
"./manipulation/var/rscriptType",
"./manipulation/wrapMap",
Expand All @@ -22,8 +22,8 @@ define( [
"./traversing",
"./selector",
"./event"
], function( jQuery, concat, push, rcheckableType,
access, rtagName, rscriptType,
], function( jQuery, concat, push, access,
rcheckableType, rtagName, rscriptType,
wrapMap, getAll, setGlobalEval, buildFragment, support,
dataPriv, dataUser, acceptData, DOMEval, nodeName ) {

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion src/serialize.js
@@ -1,6 +1,6 @@
define( [
"./core",
"./var/rcheckableType",
"./manipulation/var/rcheckableType",
"./core/init",
"./traversing", // filter
"./attributes/prop"
Expand Down

0 comments on commit 4d6b453

Please sign in to comment.