Ref #14313: NaN detection. Close gh-1352.

(cherry picked from commit 0bc0a69)
jquery · Sep 12, 2013 · 68213f2 · 68213f2
1 parent 1d57ffe
commit 68213f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/src/core.js b/src/core.js
@@ -221,7 +221,10 @@ jQuery.extend({
 	},
 
 	isNumeric: function( obj ) {
-		return !isNaN( parseFloat(obj) ) && isFinite( obj );
+		// parseFloat NaNs numeric-cast false positives (null|true|false|"")
+		// ...but misinterprets leading-number strings, particularly hex literals ("0x...")
+		// subtraction forces infinities to NaN
+		return obj - parseFloat( obj ) >= 0;
 	},
 
 	type: function( obj ) {

diff --git a/src/css.js b/src/css.js
@@ -273,8 +273,8 @@ jQuery.extend({
 				type = "number";
 			}
 
-			// Make sure that NaN and null values aren't set. See: #7116
+			// Make sure that null and NaN values aren't set. See: #7116
-			if ( value == null || type === "number" && isNaN( value ) ) {
+			if ( value == null || value !== value ) {
 				return;
 			}