Skip to content

Commit

Permalink
Fix #13335. Remove "use strict".
Browse files Browse the repository at this point in the history
  • Loading branch information
@dmethvin
dmethvin committed Feb 1, 2013
1 parent 1923da8 commit 7adee6c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
1 change: 0 additions & 1 deletion src/.jshintrc
View file
Expand Up @@ -4,7 +4,6 @@
"newcap": false, "newcap": false,
"quotmark": "double", "quotmark": "double",
"regexdash": true, "regexdash": true,
"strict": true,
"trailing": true, "trailing": true,
"undef": true, "undef": true,
"unused": true, "unused": true,
Expand Down
7 changes: 6 additions & 1 deletion src/intro.js
View file
Expand Up @@ -12,4 +12,9 @@
* Date: @DATE * Date: @DATE
*/ */
(function( window, undefined ) { (function( window, undefined ) {
"use strict";
// Can't do this because several apps including ASP.NET trace
// the stack via arguments.caller.callee and Firefox dies if
// you try to trace through "use strict" call chains. (#13335)
// Support: Firefox 18+
//"use strict";

2 comments on commit 7adee6c

@timmywil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, ASP needs to update.

@dmethvin
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to Microsoft, the code that's doing this is inside some component that has to be pushed to each Windows system as part of a platform update. So add a few months for that. And/or convince Firefox to allow non-strict code to trace through strict stacks, which probably isn't gonna happen. Since "use strict" isn't really buying us anything, it's gonna walk the plank.

Please sign in to comment.