Skip to content

Commit

Permalink
IE 9 preserves the case of the Alpha filter - maintain it in the test…
Browse files Browse the repository at this point in the history
… as well.
  • Loading branch information
jeresig committed Oct 13, 2010
1 parent ec462a3 commit 9ede46b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/unit/css.js
Expand Up @@ -145,7 +145,7 @@ if(jQuery.browser.msie) {
equals( jQuery('#foo').css('opacity'), '1', "Assert opacity is 1 when a different filter is set in IE, #1438" );

var filterVal = "progid:DXImageTransform.Microsoft.Alpha(opacity=30) progid:DXImageTransform.Microsoft.Blur(pixelradius=5)";
var filterVal2 = "progid:DXImageTransform.Microsoft.alpha(opacity=100) progid:DXImageTransform.Microsoft.Blur(pixelradius=5)";
var filterVal2 = "progid:DXImageTransform.Microsoft.Alpha(opacity=100) progid:DXImageTransform.Microsoft.Blur(pixelradius=5)";
var filterVal3 = "progid:DXImageTransform.Microsoft.Blur(pixelradius=5)";
jQuery('#foo').css("filter", filterVal);
equals( jQuery('#foo').css("filter"), filterVal, "css('filter', val) works" );
Expand Down Expand Up @@ -300,4 +300,4 @@ test(":visible selector works properly on children with a hidden parent (bug #45
expect(1);
jQuery('#table').css('display', 'none').html('<tr><td>cell</td><td>cell</td></tr>');
equals(jQuery('#table td:visible').length, 0, "hidden cell children not perceived as visible");
});
});

2 comments on commit 9ede46b

@jitter
Copy link
Contributor

@jitter jitter commented on 9ede46b Oct 13, 2010

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change now breaks the css test Setting opacity in IE doesn't duplicate opacity filter in all(?) previous IE versions (at least in IE6/8 I can confirm it) as they return alpha in lowercase.

Does this mabye originate from her http://github.com/jquery/jquery/blob/2ef8da0924623a9bdede9eeed17ec848859844b7/src/css.js#L211?

@jeresig
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - that's where it originates from - I already reverted it in a follow-up commit that... looking at the console now... I forgot to push last night haha. Here it is anyway: 8fb4d9a

Please sign in to comment.