Skip to content

Commit

Permalink
Core: make isNumeric limited to strings and numbers
Browse files Browse the repository at this point in the history
Fixes gh-2662

(cherry picked from commit 15ac848)
  • Loading branch information
timmywil authored and gibson042 committed Oct 25, 2015
1 parent cf4092e commit ada073e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
12 changes: 6 additions & 6 deletions src/core.js
Expand Up @@ -217,12 +217,12 @@ jQuery.extend( {

isNumeric: function( obj ) {

// parseFloat NaNs numeric-cast false positives (null|true|false|"")
// ...but misinterprets leading-number strings, particularly hex literals ("0x...")
// subtraction forces infinities to NaN
// adding 1 corrects loss of precision from parseFloat (#15100)
var realStringObj = obj && obj.toString();
return !jQuery.isArray( obj ) && ( realStringObj - parseFloat( realStringObj ) + 1 ) >= 0;
// As of jQuery 3.0, isNumeric is limited to
// strings and numbers (primitives or objects)
// that can be coerced to finite numbers (gh-2662)
var type = jQuery.type( obj );
return ( type === "number" || type === "string" ) &&
( obj - parseFloat( obj ) + 1 ) >= 0;
},

isEmptyObject: function( obj ) {
Expand Down
2 changes: 1 addition & 1 deletion test/unit/core.js
Expand Up @@ -479,8 +479,8 @@ QUnit.test( "isNumeric", function( assert ) {
assert.ok( t( 1.5999999999999999 ), "Very precise floating point number" );
assert.ok( t( 8e5 ), "Exponential notation" );
assert.ok( t( "123e-2" ), "Exponential notation string" );
assert.ok( t( new ToString( "42" ) ), "Custom .toString returning number" );

assert.equal( t( new ToString( "42" ) ), false, "Custom .toString returning number" );
assert.equal( t( "" ), false, "Empty string" );
assert.equal( t( " " ), false, "Whitespace characters string" );
assert.equal( t( "\t\t" ), false, "Tab characters string" );
Expand Down

0 comments on commit ada073e

Please sign in to comment.