Limit the scope of the CSS 'auto' change to just height/width. Fixes …

…#7393.
jquery · Nov 3, 2010 · d947895 · d947895
1 parent 335e0a3
commit d947895
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/css.js b/src/css.js
@@ -177,7 +177,7 @@ jQuery.each(["height", "width"], function( i, name ) {
 					}
 
 					if ( val != null ) {
-						return val;
+						return val === "" ? "auto" : val;
 					}
 				}
 
@@ -252,7 +252,7 @@ if ( document.defaultView && document.defaultView.getComputedStyle ) {
 			}
 		}
 
-		return ret === "" ? "auto" : ret;
+		return ret;
 	};
 }
 

diff --git a/test/unit/effects.js b/test/unit/effects.js
@@ -6,14 +6,18 @@ test("sanity check", function() {
 });
 
 test("show()", function() {
-	expect(27);
+	expect(28);
 
 	var hiddendiv = jQuery("div.hidden");
 
 	hiddendiv.hide().show();
 
 	equals( hiddendiv.css("display"), "block", "Make sure a pre-hidden div is visible." );
 
+	var div = jQuery("<div>").hide().appendTo("body").show();
+
+	equal( div.css("display"), "block", "Make sure pre-hidden divs show" );
+
 	QUnit.reset();
 
 	hiddendiv = jQuery("div.hidden");