Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery 2.x (3.0) still support IE 6, 7 and 8 #2150

Closed
ghost opened this issue Mar 20, 2015 · 4 comments
Closed

jQuery 2.x (3.0) still support IE 6, 7 and 8 #2150

ghost opened this issue Mar 20, 2015 · 4 comments

Comments

@ghost
Copy link

ghost commented Mar 20, 2015

Hi

I noticed something strange. If you open up the source code for latest build for jQuery 2.x (3.0) and search for IE8. A lot of hits.

See Line 1007.

Quote: " // Support: IE<8 "

Even compat branch are no longer support IE6 and 7 ?

Anyway. This is not correct with it's stated in the docs that the jQuery 2.x branch are not supporting older IE then 9.

@mgol
Copy link
Member

mgol commented Mar 20, 2015

These comments come from Sizzle which is the selector engine used by jQuery. Sizzle, as opposed to jQuery, has only one version line and supports more browsers than jQuery itself: https://github.com/jquery/sizzle/wiki#browsers

Note that there's a plan to reduce that to browsers supported by jQuery Compat (current jQuery 1.x) i.e. IE8+, see jquery/sizzle#294. This will happen in time for jQuery 3.0, the next version.

That will still mean even in jQuery version that doesn't support IE8 you'll still see some code that doesn't make sense for other browsers. Getting rid of that would require Sizzle to have two versions, though which is always a pain to maintain and gains wouldn't be large enough; there are not enough IE8-only workarounds in Sizzle to warrant a separete version.

Thanks for looking at our code and filing the bug, thought!

@mgol mgol closed this as completed Mar 20, 2015
@ghost
Copy link
Author

ghost commented Mar 20, 2015

@mzgol Not all of this comments come from Sizzle.

Line 7466 - valHooks - " // IE8-9 doesn't update selected after form reset (#2551) "

Line 8104 and line 8108 - ajax module - "// Support: IE8-11+ "

are a few examples from the jQuery Core

@mgol
Copy link
Member

mgol commented Mar 20, 2015

Line 7466 - valHooks - " // IE8-9 doesn't update selected after form reset (#2551) "

Line 8104 and line 8108 - ajax module - "// Support: IE8-11+ "

As you can se in the comments, both of these are needed for IE9 which we support. We don't delete info about older browsers if the code is still needed anyway.

@dmethvin
Copy link
Member

All of those comments cover a browser that master supports though.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants