New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred tests fail in Android 4.0 #3082

Closed
mgol opened this Issue Apr 27, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@mgol
Member

mgol commented Apr 27, 2016

Commit 7608437 introduced a regression in Deferred tests for Android 4.0. If I read that right, its strict mode is a little buggy, causing test failures: http://swarm.jquery.org/result/1233856.

We need to decide what to do about it. Considering low usage of this browser (2.2% of all Android usage as of April 4, 2016 according to Google Play stats) maybe we should skip those few tests in Android 4.0.

mgol referenced this issue Apr 27, 2016

Deferred: Remove default callback context
Employs strict mode to simplify Deferred callback context handling.

Fixes gh-3060
Closes gh-3061

gibson042 added a commit to gibson042/jquery that referenced this issue Apr 27, 2016

@gibson042 gibson042 closed this in 7f1e593 Apr 27, 2016

@mgol mgol added this to the 3.0.0 milestone Apr 27, 2016

@mgol mgol removed the Needs review label Apr 27, 2016

@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.