Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE9 and the incredible shrinking scrollboxes #3699

Closed
gibson042 opened this issue Jun 20, 2017 · 2 comments
Closed

IE9 and the incredible shrinking scrollboxes #3699

gibson042 opened this issue Jun 20, 2017 · 2 comments
Labels

Comments

@gibson042
Copy link
Member

@gibson042 gibson042 commented Jun 20, 2017

80f1c82 worked everywhere except IE9: http://swarm.jquery.org/result/2255930

Investigation traced the root cause to a mishandling by that browser of box-sizing: content-box, particularly in combination with overflow: scroll... specifically, getComputedStyle seems to always report content box dimensions, even for border-box elements, and the lack of accounting for scrollbars means that round-trip set operations shrink such elements: https://jsbin.com/zotomuqoho/edit?html,css,js,output

@mamieS99
Copy link

@mamieS99 mamieS99 commented Jun 22, 2017

I have to look at video again this looks different and i get confused of the step, will have to come back. Cant do it yet. #

@Krinkle
Copy link
Member

@Krinkle Krinkle commented Jul 18, 2017

While now fixed in IE 9, the fix subsequently broke IE 10/11. #3731

gibson042 added a commit that referenced this issue Jul 18, 2017
hubot pushed a commit to eclipse/scout.rt that referenced this issue Jun 8, 2018
jQuery 3.3.1 includes the fix for issue 3699
(jquery/jquery#3699). See commit
jquery/jquery@20cdf4e
The fix tries to detect if a browser wrongly calculates box sizes with
overflow:scroll.
The fix targets IE9 but is also wrongly active on e.g. Chrome if the web
page is initially loaded using zoom (e.g. 90%).
This was reported as issue 4029
(jquery/jquery#4029) and fixed with commit
jquery/jquery@821bf34
Unfortunately the fix for issue 4029 is not included in a jQuery release
yet.
As Scout no longer supports IE9 anyway and rarely makes use of
overflow:scroll, disable fix 3699 completely for the moment.
As soon as jQuery is updated again, this patch may be removed after good
testing.

The issue can be observed in the Scout UI e.g. in the Desktop header
form-menus when starting Chrome with 90% zoom. It is important to
refresh the page after the zoom has been set to 90% because jQuery only
calculates the css-fixes once and caches the results!
@lock lock bot locked as resolved and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants