Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support: ensure display is set to block for the support div #4844

Merged
merged 1 commit into from Feb 16, 2021

Conversation

timmywil
Copy link
Member

  • Fixes an issue with the support test in iframes in Android 8 Chrome 86+,
    where display: inline resulted in unexpected height values.

Fixes gh-4832

Summary

This PR fixes a support test failure in Chrome on Android 8.

Checklist

- Fixes an issue with the support test in iframes in Android 8 Chrome 86+,
  where display: inline resulted in unexpected height values.

Fixes jquerygh-4832
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

We also need that for master, don't we?

@timmywil
Copy link
Member Author

@mgol Unclear. See gitter.

@timmywil timmywil merged commit f8bdb12 into jquery:3.x-stable Feb 16, 2021
@timmywil timmywil deleted the feature/support branch February 16, 2021 19:34
@mgol mgol added the Support label Feb 17, 2021
@mgol mgol added this to the 3.6.0 milestone Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants