Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS: The reliableTrDimensions support test is failing on Chrome for Android #4832

Closed
mgol opened this issue Jan 25, 2021 · 0 comments · Fixed by #4845
Closed

CSS: The reliableTrDimensions support test is failing on Chrome for Android #4832

mgol opened this issue Jan 25, 2021 · 0 comments · Fixed by #4845
Assignees
@timmywil
Labels
Blocker CSS
Milestone
3.6.0

Comments

@mgol
Copy link
Member

mgol commented Jan 25, 2021

Description

The reliableTrDimensions support test is failing on Chrome for Android and not just on TestSwarm. This is highly unusual, Chrome for Android generally passes the same tests as the desktop version with the exception of some offset-related ones that only fail on TestSwarm. We need to investigate whether the issue is in the browser or in the test and - if it's the latter case - fix the support test.

Example failure:
http://swarm.jquery.org/result/3891365

See the screenshot:
Screen Shot 2021-01-25 at 18 55 50

Link to test case
@mgol mgol added this to the 3.6.0 milestone Jan 25, 2021
timmywil added a commit to timmywil/jquery that referenced this issue Feb 15, 2021
@timmywil
Support: ensure display is set to block for the support div
c761d44 
- Fixes an issue with the support test in iframes in Android 8 Chrome 86+,
  where display: inline resulted in unexpected height values.

Fixes jquerygh-4832
@timmywil timmywil mentioned this issue Feb 15, 2021
Merged
4 tasks
timmywil added a commit that referenced this issue Feb 16, 2021
@timmywil
Support: ensure display is set to block for the support div (#4844)
f8bdb12 
- Fixes an issue with the support test in iframes in Android 8 Chrome 86+,
  where display: inline resulted in unexpected height values.

Fixes gh-4832
timmywil added a commit to timmywil/jquery that referenced this issue Feb 16, 2021
@timmywil
Support: ensure display is set to block for the support div
d85e181 
- Fixes an issue with the support test in iframes in Android 8 Chrome 86+,
  where display: inline resulted in unexpected height values.

Fixes jquerygh-4832
@timmywil timmywil mentioned this issue Feb 16, 2021
Merged
4 tasks
timmywil added a commit that referenced this issue Feb 17, 2021
@timmywil
Support: ensure display is set to block for the support div
09f2543 
* Support: ensure display is set to block for the support div

- Fixes an issue with the support test in iframes in Android 8 Chrome 86+,
  where display: inline resulted in unexpected height values.

Close gh-4845
Fixes gh-4832
@snyk-bot snyk-bot mentioned this issue May 3, 2021
Closed
@gguerini gguerini mentioned this issue May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timmywil timmywil

Labels
Blocker CSS
Milestone
3.6.0
Development

Successfully merging a pull request may close this issue.

Support: ensure display is set to block for the support div timmywil/jquery
2 participants
@timmywil @mgol