Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added order true to cssNumber object to keep px off of order css property value. Fixes #14049 #1300

Closed
wants to merge 1 commit into from

Conversation

jasonmerino
Copy link
Contributor

Added "order": true to the cssNumber object so when trying to update order via .css() they don't get 'px' added to the number.

Related unit test added.

@rwaldron
Copy link
Member

LGTM

@mgol
Copy link
Member

mgol commented Jul 1, 2013

LGTM2. @jasonmerino, can you sign the CLA?

@jasonmerino
Copy link
Contributor Author

@mzgol CLA signed.

@mgol mgol closed this in ec6eb38 Jul 1, 2013
mgol pushed a commit to mgol/jquery that referenced this pull request Jul 1, 2013
@mgol
Copy link
Member

mgol commented Jul 1, 2013

Landed at ec6eb38 for master and 1c6641f for 1.x-master. Fix will be included in today's/tomorrow's release.

Thanks for your contribution! Sorry for forgetting to add you to AUTHORS.txt, I did it in a followup commit.

yansern pushed a commit to foundry-modules/jquery that referenced this pull request Nov 15, 2013
# By Richard Gibson (61) and others
# Via Dave Methvin
* commit '3b0b953d98bd13efd8c6b37d5318c5bf1e74931c': (186 commits)
  Tagging the 1.10.2 release.
  Update Sizzle to version 1.10.2
  Change the changelog header style (cherry picked from commit a44202d)
  Revert "Fix #13983. Switch to //# for sourcemaps."
  Fix #13983. Switch to //# for sourcemaps.
  Fix test for #13937 ticket. Close jquerygh-1299 (cherry picked from commit 308980e)
  Update AUTHORS.txt
  Fixes #14049: don't append px to CSS order value. Close jquerygh-1300. (cherry picked from ec6eb38)
  Update Sizzle: bower manifest
  Moved too-early assignment inside the if stmt where the var is actually used. Close jquerygh-1292. (cherry picked from commit 3a43443)
  Build: Update testswarm task to node-testswarm 1.x API
  Update Sizzle. Avoid the use of frameElement. Fixes #13980.
  Avoid jQuery(this) and a closure for .toggle(Boolean), close jquerygh-1271. (cherry picked from commit e53a919)
  Fix #13974: XML .attr("type")
  No ticket: correct typo in an example in README.md. Close jquerygh-1281. (cherry-picked from a0aa623)
  Updating the source version to 1.10.2-pre
  Tagging the 1.10.1 release.
  Fix #13789: Don't throw when module === null. Close jquerygh-1269. Close jquerygh-1280. (cherry-picked from eabb56c)
  Sizzle Update: fix #13936 - iframe reload should not affect Sizzle.
  Fix #13937: Correctly scope .finish() following multi-element .animate(). Thanks @gnarf37. Close jquerygh-1279.
  ...

Conflicts:
	package.json
	src/.jshintrc
	src/core.js
	src/deprecated.js
	src/exports.js
mescoda pushed a commit to mescoda/jquery that referenced this pull request Nov 4, 2014
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants