Build: drop bower; use npm for front-end deps #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmywil
added a commit
to timmywil/jquery
that referenced
this pull request
Jul 16, 2014
Fixes #15186 Closes jquerygh-1620
|
npm is better? |
timmywil
added a commit
to timmywil/jquery
that referenced
this pull request
Jul 16, 2014
Fixes #15186 Closes jquerygh-1620
|
@rsantostray One package manager to rule them all. |
|
Bower doesn't bring anything npm cannot do except being less reliable & solid. A huge 👍 from me. |
|
Just to be clear, this is for our internal dependency management. We will continue to support installing jquery with bower. |
| sizzleLoc = __dirname + "/../external/sizzle/dist/sizzle.js", | ||
| rversion = /Engine v(\d+\.\d+\.\d+(?:-\w+)?)/; | ||
|
|
||
| require( "colors" ); | ||
|
|
||
| /** | ||
| * Retrieve the latest tag of Sizzle from bower |
There was a problem hiding this comment.
Seems that comment must be changed too
timmywil
added a commit
that referenced
this pull request
Jul 17, 2014
Fixes #15186 Closes gh-1620 Conflicts: bower.json
This was referenced Aug 1, 2014
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
Fixes #15186 Closes jquerygh-1620 Conflicts: bower.json
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need for bower anymore.