Fix #7974: Keep animations synchronized and cleanup effects.js #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
January 11, 2011 20:41
- get rid of jQuery.each iterating over style properties to reduce function calls - cache jQuery[...] variables (e.g. jQuery.style, jQuery.extend) to minimize out-of-scope lookups and to reduce filesize - use a single var - cache elem.style and prop[p] to reduce filesize
remove useless r variable
…e it to reduce filesize
also try to reduce number of var declarations
…rs.length is not cached
|
got any before/after benchmarks? |
…ated elements. Side effect: fixes #7917, synchronize animations FTW!
|
Yep, I've built a jsFiddle with my updated effects.js added on top of jquery 1.4.4 http://jsfiddle.net/louisremi/V3Xqt/5/ (remove effects.js in "manage ressources" to see the difference) Tell me what you see. |
|
And here is the ticket: http://bugs.jquery.com/ticket/7974 |
added 10 commits
January 15, 2011 10:19
…ionnal parameters with 'false'
…ity' duration. fx.now would be the current time.
…uery.easing.swing existence since it's now built into jQuery
…pt.curAnim into opt.animatedProperties Cut more function calls! comment more of fn.animate code
|
That has been superseded by timmywil's pull. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small changes to effect.js that:
It yields some interesting performance improvement, as demonstrated in this example: http://jsfiddle.net/V3Xqt/6/ (remove patched effects.js in "manage ressources" menu and hit 'run' again to see the difference)
/!\ example might be unrealistic /!\
As it keeps animations synchronized, it fixes http://bugs.jquery.com/7917 and addresses a similar problem to http://bugs.jquery.com/6281