Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 8107 Fix And Proper Unit-tests ( Try #2 ) #219

Merged
2 commits merged into from Feb 1, 2011

Conversation

danheberden
Copy link
Member

Remember that one time I submitted this pull-req and hadn't pulled from upstream master prior? OMG those were the days!

Allows all the 1.4/1.5 forms of calling $.ajax() to work in all their glory (added a test case too):

$.ajax();
$.ajax( {} );
$.ajax( 'url' );
$.ajax( 'url', {} );

@jaubourg
Copy link
Member

jaubourg commented Feb 1, 2011

The test should be put much higher in the unit tests (right after the first success unit test actually), the fix will not work with document.location use as a url (while we support it as the url parameter in options so it should at least be documented).

@danheberden
Copy link
Member Author

I was wondering about that - as stated in the documentation, the url as the first param is of type String. The support for document.location in the options object remains.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants