New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #8104. Problem with Objects that have a numerical length property #355

Closed

kflorence wants to merge 2 commits into jquery:master from kflorence:8104

kflorence commented Apr 28, 2011

See: http://bugs.jquery.com/ticket/8104 and http://jsperf.com/jquery-ticket-8104/2

Previous discussions here: #353

kflorence added 2 commits

April 27, 2011 17:32


          Fixes #8104. Problem with Objects that have a numerical length property

fa79f82


          Performance tweak for jQuery objects

d0df016

Author

kflorence commented Apr 28, 2011

https://github.com/jquery/jquery/pull/299/files -- Seems like this was addressed here, too.

Author

kflorence commented Apr 29, 2011

Maybe this will work: https://gist.github.com/947623

ghost commented Apr 29, 2011

We use this solution in Benchmark to detect array-like objects.

Contributor

rkatic commented Apr 29, 2011

I started a discussion on isArrayLike thing: http://forum.jquery.com/topic/jquery-isarraylike-for-consistency

Author

kflorence commented Apr 29, 2011

Fixed here: #362

kflorence closed this

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.