Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Avoid unit-conversion interference from CSS upper bounds #3745

Merged
merged 4 commits into from Aug 28, 2017

Conversation

gibson042
Copy link
Member

Summary

Because Firefox getComputedStyle reports post-calculation used values (and therefore arbitrarily high margin values all result in the same used value), we need to iterate towards something else when converting units.

Fixes gh-2144

Checklist

@mention-bot
Copy link

@gibson042, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mr21, @markelog and @gnarf to be potential reviewers.

Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Krinkle
Copy link
Member

Krinkle commented Sep 14, 2017

@timmywil @gibson042 This broke the build for iOS and Safari.

http://swarm.jquery.org/project/jquery

iOS 7.0, iOS 8.3: http://swarm.jquery.org/result/2416819
screen shot 2017-09-14 at 17 01 15

iOS 9, iOS 10, Safari 9, Safari 10: http://swarm.jquery.org/result/2403960
screen shot 2017-09-14 at 17 00 38

@gibson042
Copy link
Member Author

I know; the fix is awaiting review at #3778 .

@Krinkle
Copy link
Member

Krinkle commented Sep 19, 2017

Thanks, all green now!
screen shot 2017-09-19 at 18 10 04

@lock lock bot locked as resolved and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

FireFox animation issue
4 participants