New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Skip the px-appending logic for animations of non-element props #4061

Merged
merged 1 commit into from Apr 30, 2018

Conversation

Projects
None yet
1 participant
@mgol
Member

mgol commented Apr 26, 2018

Summary

Without this change animating properties from jQuery.cssNumber on non-elements
throws an error.

This came up while working on PR gh-4055.

Checklist

CSS: Skip the px-appending logic for animations of non-element props
Without this change animating properties from jQuery.cssNumber on non-elements
throws an error.

Ref gh-4055

@mgol mgol added this to the 3.4.0 milestone Apr 26, 2018

@mgol mgol self-assigned this Apr 26, 2018

@mgol mgol merged commit f5e36bd into jquery:master Apr 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details

@mgol mgol deleted the mgol:animate-object-px branch Apr 30, 2018

@GulajavaMinistudio GulajavaMinistudio referenced this pull request Apr 30, 2018

Merged

Update upstream #47

0 of 4 tasks complete

@mgol mgol removed the Needs review label Oct 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment