Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS: Skip the px-appending logic for animations of non-element props #4061

Merged
merged 1 commit into from
Apr 30, 2018
Merged

CSS: Skip the px-appending logic for animations of non-element props #4061

merged 1 commit into from
Apr 30, 2018

Conversation

mgol
Copy link
Member

@mgol mgol commented Apr 26, 2018

Summary

Without this change animating properties from jQuery.cssNumber on non-elements
throws an error.

This came up while working on PR gh-4055.

Checklist

@mgol
CSS: Skip the px-appending logic for animations of non-element props
aa1cdea 
Without this change animating properties from jQuery.cssNumber on non-elements
throws an error.

Ref jquerygh-4055
@mgol mgol added this to the 3.4.0 milestone Apr 26, 2018
@mgol mgol self-assigned this Apr 26, 2018
@mgol mgol mentioned this pull request Apr 26, 2018
Merged
4 tasks
@mgol mgol merged commit f5e36bd into jquery:master Apr 30, 2018
@mgol mgol deleted the animate-object-px branch April 30, 2018 16:52
@GulajavaMinistudio GulajavaMinistudio mentioned this pull request Apr 30, 2018
Merged
4 tasks
@mgol mgol removed the Needs review label Oct 15, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mgol mgol

Labels
CSS
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mgol