Core: Deprecate jQuery.trim

[ShashankaNataraj]

Summary

Component: Core

• Moved jQuery.trim() from the core.js file into the deprecated.js file
• Moved corresponding unit test from test/unit/core.js to test/unit/deprecated.js

Fixes #4363

Checklist

• All authors have signed the CLA at https://cla.js.foundation/jquery/jquery
• New tests have been added to show the fix or feature works
• Grunt build and unit tests pass locally with these changes
• If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

[jsf-clabot]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ ShashankaNataraj
❌ Shashanka N

---

Shashanka N seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

[mgol]

Thanks for the PR.

Please follow our guidelines, especially for commit messages: https://contribute.jquery.org/commits-and-pull-requests/

The PR title should be named in the same format as well.

[timmywil]

The code changes look good.

[mgol]

@ShashankaNataraj Please sign our CLA.

[timmywil]

Looks like you did sign the CLA, but one of the commits has different author info. You can fix this with git commit --amend --author=ShashankaNataraj

[ShashankaNataraj]

@mgol @timmywil Thanks for your guidance. I hope the above commits do the trick! The issue was I committed with my official mail ID in the git config.

The CLA was picking up my old email ID as I have contributed to jQuery before as well!

[mgol]

Please remove the trim test from test/unit/basic.js, the tests there should work with deprecated APIs excluded.

[ShashankaNataraj]

@mgol @timmywil Does this look correct?

[mgol]

Looks good, thanks!

In the future, please name your commits according to our guidelines at https://contribute.jquery.org/commits-and-pull-requests/#commit-guidelines. The PR title should also follow the same format as the commit title.

[mgol]

(I updated the PR title to match the proper format)

[ShashankaNataraj]

@mgol Will do, thanks!

[mgol]

Moving the milestone to 3.5.0 (deprecations can only happen in minor or major releases and previously we didn't plan a minor bump on the 3.x line); I cherry-picked the change (with some necessary modifications) in 56e73e0.