Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Run tests on Travis on FirefoxHeadless as well #4524

Merged
merged 4 commits into from
Oct 21, 2019

Conversation

mgol
Copy link
Member

@mgol mgol commented Oct 21, 2019

Summary

Also, run them on both ChromeHeadless & FirefoxHeadless locally on
grunt karma:main.

Checklist

Also, run them on both ChromeHeadless & FirefoxHeadless locally on
`grunt karma:main`.
@mgol mgol added this to the 4.0.0 milestone Oct 21, 2019
@mgol mgol self-assigned this Oct 21, 2019
So far, the chrome & firefox addons were installed for all the jobs, even
the ones that weren't used for browser testing. Changing that makes those jobs
faster.
@mgol
Copy link
Member Author

mgol commented Oct 21, 2019

I wonder, should be also run tests on Firefox ESR? Since we support it... See available versions: https://docs.travis-ci.com/user/firefox

@mgol mgol force-pushed the travis-firefox branch 2 times, most recently from cae0d31 to 218f111 Compare October 21, 2019 10:51
@mgol
Copy link
Member Author

mgol commented Oct 21, 2019

OK, latest-esr installs Firefox 60 right now which is not supported by master:
https://travis-ci.org/jquery/jquery/jobs/600673312
But it should work on the 3.x-stable branch so I can try it later there.

It used to not work on Travis but now it does.
@mgol mgol requested a review from timmywil October 21, 2019 16:21
@mgol mgol changed the title Build: Run tests on Travis on FirefoxHeadless as well. Build: Run tests on Travis on FirefoxHeadless as well Oct 21, 2019
@mgol mgol merged commit 584835e into jquery:master Oct 21, 2019
@mgol mgol deleted the travis-firefox branch October 21, 2019 17:06
@mgol mgol removed the Needs review label Oct 21, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Apr 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants