Core: Fire iframe script in its context, add doc param in globalEval #4601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+5 bytes |
mgol
force-pushed
the
external-script-iframe-context
branch
from
4a62637
to
5d9974b
Compare
ghost
approved these changes
Feb 4, 2020
mgol
commented
Feb 4, 2020
…in globalEval 1. Support passing custom document to jQuery.globalEval; the script will be invoked in the context of this document. 2. Fire external scripts appended to iframe contents in that iframe context; this was already supported & tested for inline scripts but not for external ones. Fixes jquerygh-4518
mgol
force-pushed
the
external-script-iframe-context
branch
from
5d9974b
to
90f9135
Compare
timmywil
approved these changes
Feb 10, 2020
mgol
changed the title
mgol
added a commit
that referenced
this pull request
Feb 10, 2020
1. Support passing custom document to jQuery.globalEval; the script will be invoked in the context of this document. 2. Fire external scripts appended to iframe contents in that iframe context; this was already supported & tested for inline scripts but not for external ones. Fixes gh-4518 Closes gh-4601 (cherry picked from commit 4592595)
mgol
added a commit
to mgol/api.jquery.com
that referenced
this pull request
Jul 18, 2020
Since jQuery 3.5.0, jQuery.globalEval accepts an optional third parameter accepting a document in which context the code will be evaluated. This commit also adds the Document type and links it to one of the jQuery signatures; so far it was using `type="document"` which linked to a non-existent types section. Ref jquery/jquery#4601
mgol
added a commit
to jquery/api.jquery.com
that referenced
this pull request
Jul 20, 2020
Since jQuery 3.5.0, jQuery.globalEval accepts an optional third parameter accepting a document in which context the code will be evaluated. This commit also adds the Document type and links it to one of the jQuery signatures; so far it was using `type="document"` which linked to a non-existent types section. Closes gh-1168 Ref jquery/jquery#4601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
invoked in the context of this document.
this was already supported & tested for inline scripts but not for external
ones.
Fixes gh-4518
Checklist