1.7 jQuery.offset.supportsFixedPosition. Ticket #6809 #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Landed in commit f602136. |
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
…xes #6809. More Details: - jquery#477 - http://bugs.jquery.com/ticket/6809
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This initial pull request should serve as a request for comments, reviews etc.
The approach I took was to use the "fake body" created by the support module or real body if possible to determine the support for fixedPosition as early as possible, here:
https://github.com/rwldrn/jquery/pull/new/6809#L1R251
I've mapped the new support properties to their previously expected property names, here:
https://github.com/rwldrn/jquery/pull/new/6809#L0R123
I also significanty reduced the number of repetitive characters used by cacheing the style attribute value here:
https://github.com/rwldrn/jquery/pull/new/6809#L1R257
Improvements to overall readability and consistency.
This has been tested and is passing in:
If I could get some backup testing on IE9, that would be greatly appreciated.
http://bugs.jquery.com/ticket/6809