Dimensions: Add offset prop fallback to FF for unreliable TR dimensions #4808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox incorrectly (or perhaps correctly) includes table borders in computed dimensions, but they are the only one. Workaround this by testing for it and falling back to offset properties Fixes jquerygh-4529
mgol
reviewed
Nov 10, 2020
mgol
added
Dimensions
Discuss in Meeting
mgol
approved these changes
Nov 16, 2020
Comment on lines
+149
to
+154
| // Support: IE 10 - 11+ | ||
| // IE misreports `getComputedStyle` of table rows with width/height | ||
| // set in CSS while `offset*` properties report correct values. | ||
| // Support: Firefox 70+ | ||
| // Firefox includes border widths | ||
| // in computed dimensions for table rows. (gh-4529) |
There was a problem hiding this comment.
Back when we had lots of support comment, when code was guarded by one, we usually didn't comment what gets worked around as the support comment above the support test was explaining that anyway. Maybe we can remove this comment in that case here.
There was a problem hiding this comment.
Although, I see we have a similar comment on 3.x-stable here so I'm fine either way.
timmywil
removed
the
Discuss in Meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-4529
Summary
Firefox incorrectly (or perhaps correctly) includes table borders in computed
dimensions, but they are the only one. Workaround this by testing for it and
falling back to offset properties.
This applies to latest FF and so needs to go on master as well.
Checklist
+203 bytes