Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Fix the link to QUnit CSS file #5090

Merged
merged 1 commit into from Aug 29, 2022
Merged

Conversation

mgol
Copy link
Member

@mgol mgol commented Aug 14, 2022

Summary

Without this fix, the layout is fine during the test run but all the CSS is gone
when tests finish and the results are shown.

This affects commands like grunt karma:chrome-debug.

Checklist

  • New tests have been added to show the fix or feature works
  • Grunt build and unit tests pass locally with these changes
  • If needed, a docs issue/PR was created at https://github.com/jquery/api.jquery.com

Without this fix, the layout is fine during the test run but all the CSS is gone
when tests finish and the results are shown.

This affects commands like `grunt karma:chrome-debug`.
Copy link
Member

@timmywil timmywil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I actually had this change in my local stash and never committed it.

@mgol mgol merged commit 8cf39b7 into jquery:main Aug 29, 2022
@mgol mgol deleted the karma-qunit-css-fix branch August 29, 2022 15:44
@mgol mgol modified the milestones: 3.7.0, 4.0.0 Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants