Fixes #5684 - Unset the complete function just before calling it to avoid an exception creating a loop #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't think of any way we can actually unit test this... http://jsfiddle.net/X2gEP/2/ is the test case I was using. |
|
Landed in commit 8dda57f. |
|
hi might me not the right case, would like to report it though -> this crashes still in infinity |
mescoda
pushed a commit
to mescoda/jquery
that referenced
this pull request
Nov 4, 2014
…ling it to avoid an exception creating a loop. Fixes #5684. More Details: - jquery#520 - http://bugs.jquery.com/ticket/5684
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exception occurs in the complete function, it will still halt this timer loop, however since the function is being cleared out of the
optionsobject before being called it will not call the complete a second time.http://jqbug.com/5684