Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Fix regression in jQuery.text() on HTMLDocument objects #5265

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Core: Fix regression in jQuery.text() on HTMLDocument objects #5265

merged 1 commit into from
Jun 12, 2023

Conversation

Krinkle
Copy link
Member

@Krinkle Krinkle commented Jun 1, 2023 •
edited

Fixes #5264.

Size comparison, if written as minimal diff (add conditional branch):

   +54     +8 dist/jquery.js                                                   
   +19     +5 dist/jquery.min.js

Size comparison, as submitted (rewritten without "else if"):

   raw     gz Compared to 3.x-stable @ 992a66538b535d24c9ba46c3a4492665943b40c7
   +50     +4 dist/jquery.js                                                   
    +4     +1 dist/jquery.min.js

Checklist

  • New tests have been added to show the fix or feature works

@mgol mgol added Core Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. labels Jun 1, 2023
@mgol mgol added this to the 3.7.1 milestone Jun 1, 2023
mgol
mgol approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@mgol mgol removed Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Needs review labels Jun 12, 2023
@mgol mgol merged commit 44c56f8 into jquery:3.x-stable Jun 12, 2023
11 checks passed
mgol pushed a commit that referenced this pull request Jun 12, 2023
@Krinkle @mgol
Core: Fix regression in jQuery.text() on HTMLDocument objects
a75d6b5 
Fixes gh-5264
Closes gh-5265

(cherry picked from commit 44c56f8)
@mgol
Copy link
Member

mgol commented Jun 12, 2023

Landed on main in a75d6b5 and on 3.x-stable in 44c56f8.

@Krinkle Krinkle deleted the fix-text-doc branch June 13, 2023 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timmywil timmywil timmywil approved these changes

@mgol mgol mgol approved these changes

Assignees
No one assigned
Labels
Core
Milestone
3.7.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Krinkle @mgol @timmywil