Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Don't run CI push workflows for dependabot branches #5353

Merged
merged 1 commit into from Nov 13, 2023

Conversation

mgol
Copy link
Member

@mgol mgol commented Oct 30, 2023

Summary

Without this change, dependabot PRs run double checks - one set for the push part and one for the pull_request part.

I tested it on my fork.

PR against jquery/jquery (i.e. without this fix):
Screenshot 2023-10-30 at 18 45 12

PR against mgol/jquery with this fix applied:
Screenshot 2023-10-30 at 18 44 10

Checklist

Without this change, dependabot PRs run double checks - one set for the `push`
part and one for the `pull_request` part.
@mgol mgol added this to the 3.7.2 milestone Oct 30, 2023
@mgol mgol self-assigned this Oct 30, 2023
@mgol mgol requested a review from timmywil November 1, 2023 23:40
@mgol
Copy link
Member Author

mgol commented Nov 13, 2023

CI failures are just a Chrome 117-118 bug; we're ignoring that, waiting for Chrome to be updated to 119 in the image.

@mgol mgol merged commit 635cb15 into jquery:main Nov 13, 2023
8 of 13 checks passed
@mgol mgol deleted the ignore-dependabot-push-ci branch November 13, 2023 17:18
mgol added a commit that referenced this pull request Nov 13, 2023
Without this change, dependabot PRs run double checks - one set for the `push`
part and one for the `pull_request` part.

Closes gh-5353

(cherry picked from commit 635cb15)
mgol added a commit to mgol/jquery-migrate that referenced this pull request Feb 5, 2024
Without this change, dependabot PRs run double checks - one set for the `push`
part and one for the `pull_request` part.

Ref jquery/jquery#5353
mgol added a commit to jquery/jquery-migrate that referenced this pull request Feb 12, 2024
Without this change, dependabot PRs run double checks - one set for the `push`
part and one for the `pull_request` part.

Closes gh-499
Ref jquery/jquery#5353
@mgol mgol removed the Needs review label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants